-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make BagVerifier extendable #126
Open
rvanheest
wants to merge
2
commits into
LibraryOfCongress:master
Choose a base branch
from
rvanheest-DANS-KNAW:extendable-verifier
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
src/integration/java/gov/loc/repository/bagit/ExtendedBagVerifier.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package gov.loc.repository.bagit; | ||
|
||
import gov.loc.repository.bagit.domain.Bag; | ||
import gov.loc.repository.bagit.domain.Manifest; | ||
import gov.loc.repository.bagit.exceptions.CorruptChecksumException; | ||
import gov.loc.repository.bagit.exceptions.FileNotInPayloadDirectoryException; | ||
import gov.loc.repository.bagit.exceptions.InvalidBagitFileFormatException; | ||
import gov.loc.repository.bagit.exceptions.MaliciousPathException; | ||
import gov.loc.repository.bagit.exceptions.UnsupportedAlgorithmException; | ||
import gov.loc.repository.bagit.exceptions.VerificationException; | ||
import gov.loc.repository.bagit.verify.BagVerifier; | ||
|
||
import java.io.IOException; | ||
|
||
// an example of extending the BagVerifier in order to add your own checks that suffice the specific | ||
// verification rules for a bag, as defined by your project | ||
// NOTE: this cannot override the BagVerifier.isComplete or BagVerifier.isValid, as they're defined | ||
// by "The BagIt File Packaging Format" (https://tools.ietf.org/html/draft-kunze-bagit). | ||
public class ExtendedBagVerifier extends BagVerifier { | ||
|
||
public void isValidAccordingToMyValidation(final Bag bag, final boolean ignoreHiddenFiles) | ||
throws InterruptedException, CorruptChecksumException, VerificationException, | ||
MaliciousPathException, FileNotInPayloadDirectoryException, UnsupportedAlgorithmException, | ||
InvalidBagitFileFormatException, IOException { | ||
|
||
for (Manifest manifest : bag.getPayLoadManifests()) { | ||
this.checkHashes(manifest); | ||
} | ||
|
||
getManifestVerifier().verifyPayload(bag, ignoreHiddenFiles); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class doesn't actually test anything. The src/test and src/integration are for junit tests. The integration is meant to test against the bagit-suite as well as the combination of the readers and writers. You should probably put this in the src/test directory following the package name and have junit test something. That way gradle will test it as well as it being tested during compile time.