-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern cmake & target for use with add_submodule #16
Conversation
…ncies when included as submodule
Specified public/private include directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for working through the changes! I'll hold off merging the PR until I validated this in rawpy's CI.
I checked rawpy's CI and had to do the following changes:
The CMake update is fine. The OpenMP update is a minor semantic break but I think this is good as otherwise there is no way to verify that you're actually getting OpenMP if you request it. I'm going to merge this now. Thanks again for working on this, very much appreciated and long overdue :) |
Based on #15
The main consideration was to be able to be added as a submodule to other projects and link by target:
The minimum supported cmake version is 3.12 because of
FIND_PACKAGE(JPEG)
and because it's easy to install.A small change is that the repo now contains libraw as a submodule and it doesn't have to be manually downloaded. This is in order to ease the usage by tools that expect the repo to work out of the box.