Fix issue dismissing keyboard resetting value #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On android, when the keyboard was dismissed, it would reset the value of the textfield This commit changes the behaviour of the textfields to emit their values on input rather than onchange, which ensures the state is always up to date. This was an issue before because on inputs which used decimals, it would strip the decimal point during the state loop, meaning the user couldn't input them. I fixed this by only updating the internal input's value from the props when it doesn't have focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On android, when the keyboard was dismissed, it would reset the value of the textfield
This commit changes the behaviour of the textfields to emit their values on input rather than onchange, which ensures the state is always up to date.
This was an issue before because on inputs which used decimals, it would strip the decimal point during the state loop, meaning the user couldn't input them. I fixed this by only updating the internal input's value from the props when it doesn't have focus
Before:
Screen.Recording.2024-07-03.at.08.55.24.mov
After:
Screen.Recording.2024-07-03.at.08.56.35.mov