-
-
Notifications
You must be signed in to change notification settings - Fork 37
Drop support of key types other than string and Buffer #191
Conversation
Does this warrant a prerelease? That hasn't proven itself useful in the past (on levelup, leveldown) mainly because there wasn't any feedback on prereleases. |
I think we can skip that, because no feedback and also yolo. |
with |
The race issues in TLDR; everything looks good. |
One open question: this PR fixes keys, but similar issues exist on values. For example, assume we have a Should we go all the way, and also drop custom value types? |
I say yes, because it's another incompatibility that isn't easy to solve otherwise. And it's common to swap keys and values (e.g. for indexing) so they should behave largely the same (I wish I realized this sooner). Will open a second PR. |
Background: #186.
Todo:
Should also remove the need for Level/codec#51.