This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
Replace remark with hallmark #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
Nov 24, 2018
| ] | ||
| "hallmark": { | ||
| "community": "level-community", | ||
| "validateLinks": false |
There was a problem hiding this comment.
I added this temporary validateLinks option to hallmark because we have a lot of HTML anchors (<a>) in the levelup README, and remark does not parse those, leading to many lint failures.
vweevers
commented
Nov 24, 2018
| @@ -10,7 +10,7 @@ | |||
| | **Matteo Collina** | [**@mcollina**](https://github.com/mcollina) | [**@matteocollina@twitter**](https://twitter.com/matteocollina) | | |||
| | **James Halliday** | [**@substack**](https://github.com/substack) | [**@substack@twitter**](https://twitter.com/substack) | | |||
| | **David Björklund** | [**@kesla**](https://github.com/kesla) | [**@david_bjorklund@twitter**](https://twitter.com/david_bjorklund) | | |||
| | **Jake Verbaten** | [**@Raynos**](https://github.com/Raynos) | [**@raynos@twitter**](https://twitter.com/raynos) | | |||
| | **Raynos** | | | | |||
There was a problem hiding this comment.
This must be caused by some change between remark-git-contributors 0.2.1 and 0.3.0, but IMO it's not important to fix now.
ralphtheninja
approved these changes
Nov 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash on merge. Closes #614, closes #615, closes #620.
The third commit adds a lot of diff noise, because
hallmarkhas a custom list item indent option. Should we remove that fromhallmark? With remark defaults, lists look like this (two spaces):With
hallmarkthey look like (single space):