This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Add db.getMany(keys)
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
vweevers
added
semver-major
And add a clear() test for good measure
|
Would have made a separate PR for the last commit (c197496) were it not for the fact that |
ralphtheninja
approved these changes
Sep 28, 2021
juliangruber
previously requested changes
Sep 29, 2021
ralphtheninja
approved these changes
Sep 30, 2021
In other states (besides 'open') a 'Database is not open' error is now thrown. This reduces the scope of `deferred-leveldown` to what's strictly needed in `levelup` and aligns behavior. In addition, override public methods of `abstract-leveldown` instead of private methods. This has one downside: they need to do the same callback to promise conversion that `abstract-leveldown` does. The upside is that operation callbacks are not called before the db has finished opening, including in cases where `abstract-leveldown` has a fast-path, like on `db.batch([])` which because the array is empty bypasses `_batch()`. Closes #91 Closes #90
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref Level/community#101. Depends on Level/abstract-leveldown#381 and Level/memdown#212 (for tests).
Also closes #90, closes #91.