-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and dev dependencies #103
Conversation
Smoke failed with:
|
Perhaps add |
Yeah, I sometimes add that in temporarily, but normally I prefer the default behavior, to not have to cancel manually. Thanks for the suggestion. |
Smoke fails on win32-x86 with:
Turns out Node.js 23 removed support of 32-bit Windows (nodejs/node#53184) so I'll restore the |
That's fixed. Next issue is that linux-x64 fails with:
It's using Python 3.6.8. Need to update (or maybe just rebuild) https://github.com/prebuild/docker-images/blob/master/centos7-devtoolset7/Dockerfile. |
As alternative to centos7-devtoolset7 which: - No longer builds (because mirrorlist.centos.org is offline) - Doesn't support Node.js >= 18 - Doesn't support C++ 20. Ref: prebuild/prebuildify-cross#13 Ref: Level/classic-level#103 (comment)
As alternative to `centos7-devtoolset7` which: - No longer builds (because `mirrorlist.centos.org` is offline) - Doesn't support Node.js >= 18 - Doesn't support C++ 20 - Ships an EOL python version (3.6.8) which doesn't work with node-gyp 10 Ref: prebuild/prebuildify-cross#13 Ref: Level/classic-level#103 (comment)
That's fixed as well. Smoke now passes, meaning we're ready to release v2 🙂 |
Category: none
Follow-up for c177f3c. Older Electron versions will still work fine, but we stop testing them. Category: removal
Category: none
Previously we used 8.14.0 which is really old. We can't just omit the `--target` argument and use the latest version, because Node.js 23 dropped support of 32-bit Windows. The choice for 18.20.4 specifically is not really important. I just picked LTS and then the latest version within that range. The intent is 18.x. Category: change
Which means classic-level now requires glibc 2.28 (same as Node.js 18) instead of glibc 2.17. Would be a breaking change if an earlier commit didn't already drop support of Node.js < 18. Ref: prebuild/docker-images#38 Category: change
No description provided.