-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support running test suite on a levelup db #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
Apr 5, 2020
vweevers
force-pushed
the
tests-for-levelup
branch
from
April 5, 2020 16:51
d82e4b3
to
406a6ef
Compare
vweevers
added a commit
to Level/levelup
that referenced
this pull request
Apr 5, 2020
- Add db property to chained batch - Remove type checks that are also performed by abstract-leveldown Goes hand in hand with Level/abstract-leveldown#364.
As well as skipping 'start' and 'end' tests (for multileveldown).
vweevers
force-pushed
the
tests-for-levelup
branch
from
April 5, 2020 17:17
406a6ef
to
0a61ef4
Compare
Almost works on var test = require('tape')
var factory = require('level')
var tempy = require('tempy')
var suite = require('abstract-leveldown/test')
suite({
test: test,
factory: function () {
return factory(tempy.directory())
},
clear: true,
createIfMissing: false, // TODO: fails
errorIfExists: false, // TODO: fails
promises: true,
status: false,
serialize: false,
encodings: true
}) And it also works when you take out var factory = require('level-compose')(require('leveldown'), require('levelup'))
// same as above, but with `encodings: false`
// .. |
The test('test database open createIfMissing:false', function (t) {
// levelup db, opens itself
var db = testCommon.factory()
// options are ignored because it's already opening
db.open({ createIfMissing: false }, function () { /* .. */ })
}) The easiest way forward is probably to move such options to the |
vweevers
added a commit
to Level/levelup
that referenced
this pull request
Apr 11, 2020
- Add db property to chained batch - Remove type checks that are also performed by abstract-leveldown Goes hand in hand with Level/abstract-leveldown#364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as skipping 'start' and 'end' tests (for
multileveldown
) (see also Level/community#86).Doesn't change anything for existing
abstract-leveldown
implementations. Before releasing I do want to test it on:multileveldown
(as alevelup
instance)subleveldown
(same)level
Working towards Level/community#58.