danielle/remove pick history from league landing page #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Danielle254
commented
Nov 4, 2024
Danielle254
commented
|
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
choir241
previously approved these changes
Nov 4, 2024
braydoncoyer
reviewed
Nov 5, 2024
| @@ -34,7 +32,7 @@ const LeagueEntries = ({ | |||
| className={cn( | |||
| 'league-entry-container-card grid h-21 min-w-fit items-center justify-between rounded-lg border border-border bg-card p-4 text-card-foreground shadow-sm', | |||
| isEliminated ? 'bg-muted' : 'transparent', | |||
| userPickHistory.length === 0 ? 'grid-cols-2' : 'grid-cols-3', | |||
| 'grid-cols-2', | |||
There was a problem hiding this comment.
This technically could go on the line before the conditional classes, correct?
There was a problem hiding this comment.
@braydoncoyer great point! Will fix.
There was a problem hiding this comment.
@braydoncoyer addressed
Danielle254
changed the title
…nger conditional upon pick history
shashilo
approved these changes
Nov 9, 2024
alexappleget
approved these changes
Nov 11, 2024
Danielle254
deleted the
danielle/626-league-landing-page-remove-previous-picks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.