Storybook & shadcn setup #65
Conversation
emestabillo
requested review from
shashilo,
mhchen and
jayrobin
as code owners
emestabillo
changed the title
components/CustomButton.tsx
Outdated
| label, | ||
| icon: IconComponent, | ||
| className, | ||
| ...props |
There was a problem hiding this comment.
Remove this wildcard prop. Let's be explicit with what props we are allowing.
There was a problem hiding this comment.
Wildcard prop removed
components/CustomButton.tsx
Outdated
| import { LucideProps } from "lucide-react"; | ||
|
|
||
| interface ButtonProps { | ||
| variant?: |
There was a problem hiding this comment.
These are all optional, which is not ideal. Please require the props that we need.
There was a problem hiding this comment.
How would we handle the different variants?
a. button with text
b. button with icon
c. button with icon and text
There was a problem hiding this comment.
We should only be building components from the design.
| } | ||
|
|
||
| const Button = React.forwardRef<HTMLButtonElement, ButtonProps>( | ||
| ({ className, variant, size, asChild = false, ...props }, ref) => { |
There was a problem hiding this comment.
Again, let's be explicit with our props.
There was a problem hiding this comment.
This component is from Shadcn. Make adjustments?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Close to clean up in future. |
Description
Closes #53 , Closes #48
Type of change