Dominick/ Closes #613 Add unit test for <AlertTitle /> component #618
Conversation
|
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| import { AlertTitle } from './AlertTitle'; | ||
|
|
||
| describe('AlertTitle', () => { | ||
| it('renders the title text', () => { |
There was a problem hiding this comment.
Q: Based on your PR description, how are we making sure that the passed in string is a string? NIT: Your PR description, ensuring it matches the declared prop type, which is a string. doesn't match what you're testing here. Please update this.
There was a problem hiding this comment.
Doesn't TypeScript do this already? Why would it need a separate test?
There was a problem hiding this comment.
@mhchen it was more of a question about the PR description itself
There was a problem hiding this comment.
Can do! @choir241 does this work?
|
@HoldUpFjord you can add the statement "Closes #613 " to the top of your PR description. This not only makes it easy for reviewers to read the details of the issue, but it will also close the issue when this ticket gets moved to Done on the sprint board. |
HoldUpFjord
changed the title
Added a unit test to verify that the title prop in
AlertTitle.tsxrenders correctly when passed as a string.