Mai/Fix-413-added in Link to logo #446
+24
−9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { render, screen, fireEvent, waitFor } from '@testing-library/react'; | ||
| import LogoNav from './LogoNav'; | ||
|
|
||
| describe('LogoNav Component', () => { | ||
| it('renders the logo and links to the /league/all page', () => { | ||
| render(<LogoNav />); | ||
|
|
||
| const logoImage = screen.getByTestId('logo-nav'); | ||
| expect(logoImage).toBeInTheDocument(); | ||
|
|
||
| const linkElement = screen.getByRole('link', { | ||
| name: /Gridiron Survivor logo/i, | ||
|
There was a problem hiding this comment. General question, what's the forward-slashes and "i" do here? There was a problem hiding this comment. @ryandotfurrer it's regex to look for the specific word of 'Gridiron Survivor Logo'. Here's a great blog about the i in Regex: https://www.w3schools.com/jsref/jsref_regexp_i.asp. Please let me know if this makes sense :) |
||
| }); | ||
| expect(linkElement).toHaveAttribute('href', '/league/all'); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to use the datatest-id of
logo-navhere instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
data-testid="logo-nav"is currently used for the Image tag. I like the idea of adding a data-testID to test the Link tag and will implement one shortly.