Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mai/fix-added darkmode changes for register #445

Merged
merged 6 commits into from
Jul 25, 2024
Merged

mai/fix-added darkmode changes for register #445

merged 6 commits into from
Jul 25, 2024

Conversation

vmaineng
Copy link
Contributor

@vmaineng vmaineng commented Jul 20, 2024 •
edited
Loading

fixes #412

  1. updated Login CSS to Register's CSS
  2. wrote unit test to ensure dark mode was included
Screenshot 2024-07-20 at 12 07 48 PM image

@vmaineng vmaineng requested review from shashilo and mhchen as code owners July 20, 2024 18:56
@appwrite Appwrite
Copy link

appwrite bot commented Jul 20, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Cursor pagination performs better than offset pagination when loading further pages

@vercel Vercel
Copy link

vercel bot commented Jul 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:30am
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 0:30am

@vmaineng vmaineng marked this pull request as draft July 20, 2024 18:56
@vmaineng vmaineng changed the title added in draft changes for register mai/fix-added in draft changes for register Jul 20, 2024
@vmaineng vmaineng marked this pull request as ready for review July 20, 2024 19:31
ryandotfurrer
ryandotfurrer previously approved these changes Jul 20, 2024
View reviewed changes
@vmaineng vmaineng changed the title mai/fix-added in draft changes for register mai/fix-added darkmode changes for register Jul 20, 2024
shashilo
shashilo reviewed Jul 22, 2024
View reviewed changes
app/(main)/register/page.test.tsx Outdated
@@ -47,7 +47,11 @@ describe('Register', () => {
beforeEach(() => {
jest.clearAllMocks();

render(<Register />);
render(
<div className="dark">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I thought our default tailwind theme was already dark?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought I had to "mock' per se the dark theme in the testing, but I removed the div tag and the test is still passing. Thanks for bringing this up!

@vmaineng vmaineng merged commit e546602 into develop Jul 25, 2024
5 checks passed
@vmaineng vmaineng deleted the mai/fix-412-bug-bash-registration-page-should-be branch July 25, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandotfurrer ryandotfurrer ryandotfurrer approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Bash: Registration page should be dark mode
3 participants
@vmaineng @shashilo @ryandotfurrer