Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#411): added redirect to login/page.tsx to redirect users #437

Merged
merged 6 commits into from
Jul 25, 2024
Merged

fix(#411): added redirect to login/page.tsx to redirect users #437

merged 6 commits into from
Jul 25, 2024

Conversation

vazquezea96
Copy link
Contributor

  • Added useRouter to the login page so users get redirected to /league/all if they are already signed in and navigate to /login.
  • Added unit test for the route.push function as well.

@vazquezea96 vazquezea96 linked an issue Jul 18, 2024 that may be closed by this pull request
Bug Bash: Redirect user to Leagues page if they are already logged in #411
Closed
@appwrite Appwrite
Copy link

appwrite bot commented Jul 18, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
You can use Avatars API to generate QR code for any text or URLs

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:58pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:58pm

ryandotfurrer
ryandotfurrer approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🏻 👏🏻 👏🏻

@vazquezea96 vazquezea96 merged commit a21dfbd into develop Jul 25, 2024
5 checks passed
@vazquezea96 vazquezea96 deleted the eduardo/411-bug-bash-redirect-user-to-leagues-page-if-they-are-already-logged-in branch July 25, 2024 17:58
Clue355 pushed a commit that referenced this pull request Jul 26, 2024
@vazquezea96 @Clue355
fix(#411): added redirect to login/page.tsx to redirect users (#437)
ec5f1c9 
- Added `useRouter` to the login page so users get redirected to
`/league/all` if they are already signed in and navigate to `/login`.
- Added unit test for the `route.push` function as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandotfurrer ryandotfurrer ryandotfurrer approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Bash: Redirect user to Leagues page if they are already logged in
3 participants
@vazquezea96 @shashilo @ryandotfurrer