Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#355 - temp auto assign GIS league on register #404

Merged
merged 12 commits into from
Jul 16, 2024
Merged

#355 - temp auto assign GIS league on register #404

merged 12 commits into from
Jul 16, 2024

Conversation

chris-nowicki
Copy link
Contributor

fixes: #355

Temporarily auto assign new registered users to the GiS league.

@appwrite Appwrite
Copy link

appwrite bot commented Jul 14, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Cursor pagination performs better than offset pagination when loading further pages

@vercel Vercel
Copy link

vercel bot commented Jul 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 2:11am
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 2:11am

@chris-nowicki chris-nowicki marked this pull request as ready for review July 14, 2024 22:32
vmaineng
vmaineng reviewed Jul 14, 2024
View reviewed changes
functions/userAuth.js Outdated
if (
req.method === 'POST' &&
req.body.email &&
req.body.email &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Chris! Will you please explain why req.body.email is used twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave this to @choir27 to explain since it's remaining from his code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was supposed to be req.body.name, but i made the mistake of using req.body.email instead. @chris-nowicki you're more than welcome to change this if you need to.

ryandotfurrer
ryandotfurrer approved these changes Jul 16, 2024
View reviewed changes
functions/userAuth.js Show resolved Hide resolved
functions/userAuth.js Show resolved Hide resolved
@chris-nowicki chris-nowicki merged commit 777b62a into develop Jul 16, 2024
7 checks passed
@chris-nowicki chris-nowicki deleted the chris/auto-assign-league branch July 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaineng vmaineng vmaineng left review comments

@choir241 choir241 choir241 left review comments

@ryandotfurrer ryandotfurrer ryandotfurrer approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEE: Auto assign any new registrants to the The GIS OG Crew League with 1 entry
5 participants
@chris-nowicki @shashilo @ryandotfurrer @choir241 @vmaineng