Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: scroll bar issue #386

Merged
merged 5 commits into from
Jul 15, 2024
Merged

BUG: scroll bar issue #386

merged 5 commits into from
Jul 15, 2024

Conversation

vazquezea96
Copy link
Contributor

fix #339:

  • removed padding-bottom from layout.tsx file. Login and Sign-Up pages are now flush.

@vazquezea96 vazquezea96 linked an issue Jul 11, 2024 that may be closed by this pull request
BUG: scroll bar issue #339
Closed
@vercel Vercel
Copy link

vercel bot commented Jul 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:18pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:18pm

@appwrite Appwrite
Copy link

appwrite bot commented Jul 11, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Cursor pagination performs better than offset pagination when loading further pages

ryandotfurrer
ryandotfurrer requested changes Jul 11, 2024
View reviewed changes
app/layout.tsx Outdated Show resolved Hide resolved
@vazquezea96
fix: added back padding to sizes smaller than 1280 and added breakpoi…
163f85c 
…nt to remove padding to sizes 1280 and bigger.
ryandotfurrer
ryandotfurrer previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shashilo
shashilo requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@shashilo shashilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you made are more of a hack than the correct fix. By doing so, you only fixed 1 screen size. There's a root cause to this issue, and it lies in the base construction of the DOM elements. Take a look at that and the answer will be there.
image

ryandotfurrer
ryandotfurrer approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@ryandotfurrer ryandotfurrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vazquezea96 vazquezea96 requested a review from shashilo July 14, 2024 01:59
@vazquezea96 vazquezea96 merged commit 6f9356a into develop Jul 15, 2024
7 checks passed
@vazquezea96 vazquezea96 deleted the 339-bug-scroll-bar-issue branch July 15, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandotfurrer ryandotfurrer ryandotfurrer approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: scroll bar issue
3 participants
@vazquezea96 @shashilo @ryandotfurrer