added in alert notifications #343

alexappleget · 2024-06-27T17:53:26Z

Integrate toast notifications into our site's user interface to enhance user experience by providing clear and timely feedback for important actions and events.

Acceptance Criteria:

Toast notifications appear in a non-intrusive manner somewhere on the screen.
Notifications display relevant information such as success messages, error alerts, and action confirmations.
Users can interact with notifications, including dismissing them and clicking through to relevant pages.
Design ensures responsiveness across different devices and adheres to our site's existing UI/UX guidelines.
Notifications are tested thoroughly in development and staging environments for functionality and user acceptance.

appwrite · 2024-06-27T17:53:29Z

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function	ID	Status	Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function	ID	Status	Action
userAuth	`6626fef885a9f630442b`	Failed	View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Appwrite has a Discord community with over 16 000 members. Come join us!

vercel · 2024-06-27T17:53:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gridiron-survivor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 15, 2024 1:38pm
gridiron-survivor-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 15, 2024 1:38pm

vmaineng · 2024-06-27T22:57:40Z

app/register/page.tsx

@@ -111,6 +114,9 @@ const Register = (): JSX.Element => {
      router.push('/weeklyPicks');
    } catch (error) {
      console.error('Registration Failed', error);
+      toast.custom(
+        <Alert variant={AlertVariants.Error} message="Something went wrong." />,
+      );
    }


is there a toast for successfully registering?

I can add it in, but when you register successfully it just redirects you to /weeklyPicks. I can find a way to add it in so it pops up when you're on the /weeklyPicks page after registering

vmaineng · 2024-06-27T23:00:30Z

app/weeklyPicks/WeeklyPicks.tsx

@@ -100,6 +100,9 @@ const WeeklyPicks = ({ NFLTeams, currentGameWeek }: Props): JSX.Element => {

    if (!gameGroupData || !weeklyPicksData) {
      console.error('Error getting game data');
+      toast.custom(
+        <Alert variant={AlertVariants.Error} message="Something went wrong." />,
+      );
      return;
    }


I was curious in line 174, could we have You picked {currentUserPick[user.id].team} was successful => You picked Falcons was successful. Thoughts? :)

i definitely can! I'll give that a try so people know for sure that the system saw what they picked.

shashilo

You'll need to add unit test to ensure these notifications are firing when they should be.

shashilo · 2024-06-28T04:12:01Z

components/Form/Form.tsx

+    toast.custom(
+      <Alert
+        variant={AlertVariants.Error}
+        message="You're missing information."


When does this fire? It doesn't seem like the right message or even if it needs an alert.

… not seeing a value of having one there

shashilo · 2024-07-03T18:47:23Z

context/AuthContextProvider.tsx

@@ -60,7 +63,16 @@ export const AuthContextProvider = ({
      await account.createEmailPasswordSession(user.email, user.password);
      getUser();
      router.push('/weeklyPicks');
+      toast.custom(


The unit test for logging in to shoe the toast notification should go in this unit test file. There's none right now, so we'll need to create one. Only add test case for what you are touching though.

shashilo · 2024-07-03T18:48:21Z

app/login/page.test.tsx

+    }
+
+    await mockLoginAccount(pretendUser);
+    expect(account.createEmailPasswordSession).toBeInstanceOf(Object);


There's no reason to test that this is an object. Also, createEmailPasswordSession is not a part of this file and doesn't need to be tested. Remove these test and test the alert logic in AuthContextProvider.

shashilo · 2024-07-03T18:50:02Z

app/register/page.test.tsx

@@ -19,6 +22,8 @@ const mockUseAuthContext = {
  isSignedIn: false,
 };

+account.create = jest.fn();


Why are we mocking this function?

shashilo · 2024-07-03T18:53:01Z

app/login/page.test.tsx

+    await mockLoginAccount(pretendUser);
+    expect(account.createEmailPasswordSession).toBeInstanceOf(Object);
+
+    render(<Alert variant={AlertVariants.Success} message="You've successfully logged in!" />)


FYI, this is not testing, this is executing the component. We want to test that the component is on the screen with the variant and message we expect. In line is executing the component onto the screen.

shashilo · 2024-07-03T18:54:38Z

app/register/page.test.tsx

@@ -102,4 +107,40 @@ describe('Register', () => {

    mockUseAuthContext.isSignedIn = false;
  });
+
+  test('successfully registers and shows success notification', async () => {


Same with these test. This is incorrectly tested. OnSubmit, it's either going to pass or fail. You need to mock the response of a success or failure. Then, the alert will show up within the component. Check that the alert is in the component and we're expecting the correct variant and message.

ryandotfurrer

Lots of nit picks but if I don't call out the lack of alphabetically sorting props and such, Shashi will

app/login/page.test.tsx

app/register/page.test.tsx

ryandotfurrer · 2024-07-13T19:41:34Z

app/register/page.test.tsx

+      expect(toast.custom).toHaveBeenCalledWith(
+        <Alert
+          variant={AlertVariants.Error}
+          message="Something went wrong!"


Please sort alphabetically

I feel the need to not alphabetize this as I always define the type of variant first before providing a custom message. The message is always based on the variant type.

app/register/page.tsx

ryandotfurrer · 2024-07-13T19:42:51Z

context/AuthContextProvider.test.tsx

+    );
+  });
+
+  test('should show error notification after a login attempt errors', async () => {


nit: change verbiage to "... after a login attempt ~~errors~~ fails"

ryandotfurrer · 2024-07-13T19:42:59Z

context/AuthContextProvider.tsx

@@ -19,7 +20,7 @@ type UserCredentials = {
 type AuthContextType = {
  isSignedIn: boolean;
  setIsSignedIn: React.Dispatch<React.SetStateAction<boolean>>;
-  loginAccount: (user: UserCredentials) => Promise<void | Error>; // eslint-disable-line no-unused-vars
+  login: (user: UserCredentials) => Promise<void | Error>; // eslint-disable-line no-unused-vars
  logoutAccount: () => Promise<void>;
  getUser: () => Promise<IUser | undefined>;


Please sort alphabetically

ryandotfurrer · 2024-07-13T19:43:05Z

context/AuthContextProvider.tsx

@@ -123,7 +122,7 @@ export const AuthContextProvider = ({
    () => ({
      isSignedIn,
      setIsSignedIn,
-      loginAccount,
+      login,
      logoutAccount,
      getUser,


Please sort alphabetically

ryandotfurrer

LGTM

added in alert notifications

fba4af3

alexappleget requested review from shashilo and mhchen as code owners June 27, 2024 17:53

vmaineng reviewed Jun 27, 2024

View reviewed changes

added in changes to successful team picked

fc32803

vercel bot deployed to Preview – gridiron-survivor-storybook June 27, 2024 23:16 View deployment

vercel bot deployed to Preview – gridiron-survivor June 27, 2024 23:17 View deployment

shashilo requested changes Jun 28, 2024

View reviewed changes

alexappleget added 2 commits June 28, 2024 10:14

Merge branch 'develop' into alex/integrate-alert-notifications

764951c

running first test for successful login notification

ffbdad8

vercel bot deployed to Preview – gridiron-survivor June 28, 2024 20:25 View deployment

vercel bot deployed to Preview – gridiron-survivor-storybook June 28, 2024 20:26 View deployment

moved test inside main function

67ed274

vercel bot deployed to Preview – gridiron-survivor June 28, 2024 20:39 View deployment

vercel bot deployed to Preview – gridiron-survivor-storybook June 28, 2024 20:40 View deployment

alexappleget added 2 commits June 28, 2024 19:38

added error alert the catch(error) inside loginAccount()

aa8b016

added in alert notifications. also deleted the one in Form.tsx due to…

5508569

… not seeing a value of having one there

vercel bot deployed to Preview – gridiron-survivor-storybook July 1, 2024 19:00 View deployment

vercel bot deployed to Preview – gridiron-survivor July 1, 2024 19:01 View deployment

adding tests for login success and fail

683507f

vercel bot deployed to Preview – gridiron-survivor-storybook July 1, 2024 21:52 View deployment

vercel bot deployed to Preview – gridiron-survivor July 1, 2024 21:53 View deployment

adding in toast notifications and created tests for each

ac30077

vercel bot deployed to Preview – gridiron-survivor July 2, 2024 21:03 View deployment

vercel bot deployed to Preview – gridiron-survivor-storybook July 2, 2024 21:04 View deployment

shashilo requested changes Jul 3, 2024

View reviewed changes

updated AuthContextProvider test

b877ad4

vercel bot deployed to Preview – gridiron-survivor-storybook July 12, 2024 16:38 View deployment

vercel bot had a problem deploying to Preview – gridiron-survivor July 12, 2024 16:39 Failure

changed mock test names from mockLoginAccount to mockLogin

faeed75

vercel bot deployed to Preview – gridiron-survivor-storybook July 12, 2024 16:42 View deployment

vercel bot had a problem deploying to Preview – gridiron-survivor July 12, 2024 16:43 Failure

updated router for login()

95acdea

vercel bot deployed to Preview – gridiron-survivor-storybook July 12, 2024 16:49 View deployment

vercel bot had a problem deploying to Preview – gridiron-survivor July 12, 2024 16:49 Failure

update

11df8d0

vercel bot deployed to Preview – gridiron-survivor-storybook July 12, 2024 17:01 View deployment

vercel bot had a problem deploying to Preview – gridiron-survivor July 12, 2024 17:02 Failure

update

ade2ab8

vercel bot had a problem deploying to Preview – gridiron-survivor July 12, 2024 17:06 Failure

vercel bot deployed to Preview – gridiron-survivor-storybook July 12, 2024 17:07 View deployment

added param for login()

93cce3a

vercel bot had a problem deploying to Preview – gridiron-survivor July 12, 2024 17:08 Failure

vercel bot deployed to Preview – gridiron-survivor-storybook July 12, 2024 17:09 View deployment

changed router type to AppRouterInstance

5d01e5d

vercel bot deployed to Preview – gridiron-survivor July 13, 2024 01:38 View deployment

vercel bot deployed to Preview – gridiron-survivor-storybook July 13, 2024 01:39 View deployment

ryandotfurrer requested changes Jul 13, 2024

View reviewed changes

alphabetized

3c28073

vercel bot deployed to Preview – gridiron-survivor July 15, 2024 13:37 View deployment

vercel bot deployed to Preview – gridiron-survivor-storybook July 15, 2024 13:38 View deployment

shashilo approved these changes Jul 15, 2024

View reviewed changes

shashilo requested review from ryandotfurrer and vmaineng July 15, 2024 15:36

ryandotfurrer approved these changes Jul 15, 2024

View reviewed changes

alexappleget merged commit af844dd into develop Jul 15, 2024
7 checks passed

alexappleget deleted the alex/integrate-alert-notifications branch July 15, 2024 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added in alert notifications #343

added in alert notifications #343

alexappleget commented Jun 27, 2024 •

edited

Loading

appwrite bot commented Jun 27, 2024 •

edited

Loading

vercel bot commented Jun 27, 2024 •

edited

Loading

vmaineng Jun 27, 2024

alexappleget Jun 27, 2024

vmaineng Jun 27, 2024

alexappleget Jun 27, 2024

shashilo left a comment

shashilo Jun 28, 2024

shashilo Jul 3, 2024

shashilo Jul 3, 2024

shashilo Jul 3, 2024

shashilo Jul 3, 2024

shashilo Jul 3, 2024

ryandotfurrer left a comment

ryandotfurrer Jul 13, 2024

alexappleget Jul 15, 2024

ryandotfurrer Jul 13, 2024

ryandotfurrer Jul 13, 2024

ryandotfurrer Jul 13, 2024

ryandotfurrer left a comment

added in alert notifications #343

added in alert notifications #343

Conversation

alexappleget commented Jun 27, 2024 • edited Loading

appwrite bot commented Jun 27, 2024 • edited Loading

vercel bot commented Jun 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shashilo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryandotfurrer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryandotfurrer left a comment

Choose a reason for hiding this comment

alexappleget commented Jun 27, 2024 •

edited

Loading

appwrite bot commented Jun 27, 2024 •

edited

Loading

vercel bot commented Jun 27, 2024 •

edited

Loading