Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#273): a11y audit signup page #303

Merged
merged 58 commits into from
Oct 23, 2024
Merged

Conversation

CorinaMurg
Copy link
Contributor

@CorinaMurg CorinaMurg commented Jun 8, 2024

Fixes: #273

Changes:

  • add title element (completed by Chris). This involved setting up a server-side page, now responsible for rendering the Register component and setting its metadata (title and description). This approach is what Next.js expects. It wants to integrate the metadata into the server response when the page is initially loaded.
  • add FormLabel to input fields
  • create test for Label component

Remaining (until design updates):

  • change input border color to meet contrast ratio

@CorinaMurg CorinaMurg added Design UI/UX a11y accessibility related labels Jun 8, 2024
Copy link

appwrite bot commented Jun 8, 2024

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function has been successfully deployed.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b ready Ready View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
Cursor pagination performs better than offset pagination when loading further pages

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 4:46pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 4:46pm

components/Label/Label.tsx Outdated Show resolved Hide resolved
components/Label/Label.test.tsx Show resolved Hide resolved
components/LinkCustom/LinkCustom.test.tsx Outdated Show resolved Hide resolved
components/LinkCustom/LinkCustom.tsx Outdated Show resolved Hide resolved
components/WeeklyPickButton/WeeklyPickButton.tsx Outdated Show resolved Hide resolved
choir241
choir241 previously approved these changes Oct 21, 2024
@CorinaMurg CorinaMurg merged commit 6204626 into develop Oct 23, 2024
5 checks passed
@CorinaMurg CorinaMurg deleted the corina/a11y-audit-signup-page branch October 23, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y accessibility related Design UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility Audit Signup Page
7 participants