Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mai/fix cookie weeklyapi #247

Merged
merged 68 commits into from
May 31, 2024
Merged

Mai/fix cookie weeklyapi #247

merged 68 commits into from
May 31, 2024

Conversation

vmaineng
Copy link
Contributor

@vmaineng vmaineng commented May 16, 2024 •
edited
Loading

Fixes #200
1). removed grabCache function
2) Removed IUserWeeklyPick, weeklyPick, and useweeklypick
3) Modified allData to object

@vmaineng vmaineng requested review from shashilo and mhchen as code owners May 16, 2024 01:06
@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gridiron-survivor ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:05pm
gridiron-survivor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:05pm

@appwrite Appwrite
Copy link

appwrite bot commented May 16, 2024 •
edited
Loading

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function ID Status Action
Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application
Project ID: 6616ea581ef9f5521c7d

Function ID Status Action
userAuth 6626fef885a9f630442b failed Failed View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know?
You can use Avatars API to generate QR code for any text or URLs

@vmaineng vmaineng changed the base branch from develop to chris/fix-userResult-object May 16, 2024 01:08
@Clue355 Clue355 self-requested a review May 16, 2024 03:23
Clue355
Clue355 requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Clue355 Clue355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll have to delete where it calls grab cache too on line 135

@vmaineng vmaineng marked this pull request as draft May 16, 2024 16:53
@chris-nowicki chris-nowicki marked this pull request as ready for review May 29, 2024 14:02
shashilo
shashilo previously approved these changes May 29, 2024
View reviewed changes
utils/utils.ts Outdated Show resolved Hide resolved
utils/utils.ts Outdated Show resolved Hide resolved
Clue355
Clue355 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Clue355 Clue355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@chris-nowicki chris-nowicki merged commit 1aa5f2d into develop May 31, 2024
7 checks passed
@chris-nowicki chris-nowicki deleted the mai/fix-cookie-weeklyapi branch May 31, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-nowicki chris-nowicki chris-nowicki left review comments

@Clue355 Clue355 Clue355 approved these changes

@shashilo shashilo shashilo approved these changes

@mhchen mhchen Awaiting requested review from mhchen mhchen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove cookie and retrieve actual user results for weekly picks
4 participants
@vmaineng @shashilo @Clue355 @chris-nowicki