Feat es lint #123
Feat es lint #123
Conversation
chris-nowicki
requested review from
shashilo,
mhchen and
jayrobin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.eslintrc.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": ["plugin:jsx-a11y/recommended", "next/core-web-vitals"] | |||
There was a problem hiding this comment.
What ESLINT rules are included in both of these?
There was a problem hiding this comment.
ESLINT Rules included:
- next plugin: https://nextjs.org/docs/pages/building-your-application/configuring/eslint#eslint-plugin
- eslint recommended rules identified by green checkmark: https://eslint.org/docs/latest/rules/
- Jsx-A11Y: https://www.npmjs.com/package/eslint-plugin-jsx-a11y#supported-rules
|
I want to ensure we have NO WARNINGS. Any rule we set up is an ERROR. This will stop devs from ignoring warnings. |
Agreed. I think there are some default ones we may be able to suppress but right now you have to do it rule by rule in the config file. I am not finding anything that turns off global warnings. There is a quiet option that I added into the package.json script that is supposed to show only errors when run: "scripts": {
...
"lint": "next lint --quiet"
} |
Fixes #66 - adds the ability to lint our project using eslint ## Setup & Run - There are two new lint dev dependency packages: `eslint-config-next` & `eslint-plugin-jsx-a11y` so be sure to install them by running `pnpm i` - Type `npm run lint` to lint the project --------- Co-authored-by: Shashi Lo <[email protected]>
Fixes #66 - adds the ability to lint our project using eslint
Setup & Run
eslint-config-next&eslint-plugin-jsx-a11yso be sure to install them by runningpnpm inpm run lintto lint the project