feat: add prettier to project

[ryandotfurrer]

Added prettier files and created a writeup on installing it from scratch.

We need to make sure we add prettier to the ESLint config file so they do not interfere with one another.

{
  "extends": [... "prettier"]
}

Also updated the README

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gridiron-survivor	❌ Failed (Inspect)			Apr 12, 2024 4:23pm

[choir241]

Image is not viewable in README.md, returns Invalid upstream response (403) when clicking on image link.

Also when I tried to follow the README instructions, I get the following error for the editor.defaultFormater property when trying to put "esbenp.prettier-vscode" as its value: Value is not accepted

• Tried putting it in dart object
• Tried putting it in settings.json object

[choir241]

Your PR seems to be failing the Vercel check, please look into this.

@ryandotfurrer please review my comments.

[emestabillo]

@ryandotfurrer Please also switch the base branch to develop

[shashilo]

Everything looks good, expect that broken image.

[chris-nowicki]

Added prettier files and created a writeup on installing it from scratch.

We need to make sure we add prettier to the ESLint config file so they do not interfere with one another.

{
  "extends": [... "prettier"]
}

Also updated the README

question for @ryandotfurrer : Why are we going to lint styling of code? We can either automatically format it on save or by running an npm command. @shashilo what do you think? I am open to both! just never linted prettier before and not sure I understand why we would?

[ryandotfurrer]

question for @ryandotfurrer : Why are we going to lint styling of code? We can either automatically format it on save or by running an npm command. @shashilo what do you think? I am open to both! just never linted prettier before and not sure I understand why we would?

@chris-nowicki to my understanding, this is not linting Prettier, but instead is turning off any ESLint rules that may conflict with our Prettier config and ensures that Prettier's formatting takes precedence over anything ESLint might do.

This allows us to use Prettier to do the code formatting, but allows ESLint to catch code issues. In my opinion, letting each tool do what they do best.

@shashilo, what are your thoughts?

[ryandotfurrer]

@ryandotfurrer Please also switch the base branch to develop

@shashilo did this for me while I was at work. Thank you, Shashi.

[ryandotfurrer]

@choir27 Image is not viewable in README.md, returns Invalid upstream response (403) when clicking on image link.

@shashilo Everything looks good, expect that broken image.

It is interesting to me that when I view my fork and look at the README.md the picture is there just fine. View the branch's README and see for yourself.

[ryandotfurrer]

@choir27 Image is not viewable in README.md, returns Invalid upstream response (403) when clicking on image link.

@shashilo Everything looks good, expect that broken image.

It is interesting to me that when I view my fork and look at the README.md the picture is there just fine. View the branch's README and see for yourself.

@chris-nowicki sent me a screenshot of the image not working, so I uploaded the image to a different service and changed the URL. Please let me know if it does not work.

[shashilo]

Prettier should control the formatting of the coding, while linting catches coding rule errors. We'll have to get them in to see how they work together.

[ryandotfurrer]

Closing to start over using pnpm and see if that resolves my issues with the vercel deployment checks.