Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Create input loading spinner #91

Closed
2 tasks
shashilo opened this issue Mar 22, 2024 · 2 comments · Fixed by #399
Closed
2 tasks

UX: Create input loading spinner #91

shashilo opened this issue Mar 22, 2024 · 2 comments · Fixed by #399
Assignees
Labels
point-3 within 1 day UI/UX

Comments

@shashilo
Copy link
Collaborator

shashilo commented Mar 22, 2024

https://react.fluentui.dev/?path=/docs/components-spinner--default#appearance

Shadcn doesn't have a spinner component. We need to create a simple one.

Acceptance Criteria:

  • When a user clicks a submit button, the text should be replaced by a spinner
  • When a user clicks a submit button, the button should be disabled from being clicked again
@shashilo shashilo converted this from a draft issue Mar 22, 2024
@shashilo shashilo added UI/UX point-3 within 1 day labels Mar 22, 2024
@shashilo shashilo moved this from Tasks To Do to Epics in Gridiron Survivor Sprint Board Mar 28, 2024
@shashilo shashilo added epic and removed epic labels Mar 28, 2024
@shashilo shashilo moved this from Epics to Tasks To Do in Gridiron Survivor Sprint Board Mar 28, 2024
@shashilo shashilo added blocked and removed blocked labels Apr 10, 2024
@shashilo shashilo moved this from Tasks To Do to Backlog in Gridiron Survivor Sprint Board Apr 15, 2024
@shashilo shashilo moved this from Backlog to Tasks To Do in Gridiron Survivor Sprint Board May 6, 2024
@shashilo shashilo moved this from Tasks To Do to Backlog in Gridiron Survivor Sprint Board May 6, 2024
@shashilo shashilo moved this from Backlog to To Do in Gridiron Survivor Sprint Board Jun 27, 2024
@ryandotfurrer ryandotfurrer moved this from To Do to In Progress in Gridiron Survivor Sprint Board Jun 30, 2024
@ryandotfurrer ryandotfurrer moved this from In Progress to To Do in Gridiron Survivor Sprint Board Jul 1, 2024
@jasonetorres
Copy link
Member

duplicate, closing and moving forward with other ticket

@ryandotfurrer ryandotfurrer reopened this Jul 1, 2024
@shashilo shashilo moved this from Done to To Do in Gridiron Survivor Sprint Board Jul 1, 2024
@shashilo shashilo changed the title Create UX loading spinner UX: Create input loading spinner Jul 1, 2024
@ryandotfurrer ryandotfurrer moved this from To Do to In Progress in Gridiron Survivor Sprint Board Jul 4, 2024
@ryandotfurrer
Copy link
Member

I've begun working on this, view my branch.

The spinner is working as expected, I just need to figure out how to make it's container the same size as what it is being nested in.

@ryandotfurrer ryandotfurrer linked a pull request Jul 13, 2024 that will close this issue
2 tasks
@ryandotfurrer ryandotfurrer moved this from To Do to In Review in Gridiron Survivor Sprint Board Jul 13, 2024
@ryandotfurrer ryandotfurrer moved this from In Review to In Progress in Gridiron Survivor Sprint Board Jul 23, 2024
@ryandotfurrer ryandotfurrer moved this from In Progress to In Review in Gridiron Survivor Sprint Board Aug 2, 2024
@ryandotfurrer ryandotfurrer moved this from In Review to In Progress in Gridiron Survivor Sprint Board Aug 20, 2024
@ryandotfurrer ryandotfurrer moved this from In Progress to In Review in Gridiron Survivor Sprint Board Aug 21, 2024
shashilo added a commit that referenced this issue Sep 20, 2024
https://github.com/user-attachments/assets/0577e7e5-846f-4b11-b139-f9ac67ad5109

I created the `LoadingSpinner` component which is designed to be used in
buttons when sending data to the database. It has a
`min-width/max-width` and `min-height/max-height` equal to tailwind's
`w-7/w-9` and `h-7/h-9` so it fits within the smallest and largest size
variants of the `Button` component.

- [X] When a user clicks a submit button, the text should be replaced by
a spinner
- [X] When a user clicks a submit button, the button should be disabled
from being clicked again

Closes #91
@github-project-automation github-project-automation bot moved this from In Review to Done in Gridiron Survivor Sprint Board Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
point-3 within 1 day UI/UX
Projects
3 participants