fix(#273): remove the hard-coded data-testid

LetsGetTechnical · Jul 7, 2024 · a1efcba · a1efcba
1 parent 9777134
commit a1efcba
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/app/register/Register.tsx b/app/register/Register.tsx
@@ -134,7 +134,12 @@ const Register = (): JSX.Element => {
             </h1>
             <p className="pb-4 font-normal leading-7 text-zinc-500">
               If you have an existing account{' '}
-              <LinkCustom href="/login">Login!</LinkCustom>
+              <LinkCustom 
+                href="/login"
+                data-testid="login-link"
+              >
+                Login!
+              </LinkCustom>
             </p>
 
             <Form {...form}>
@@ -214,7 +219,12 @@ const Register = (): JSX.Element => {
                   disabled={isDisabled}
                 />
                 <p className="pb-4 font-normal leading-7 text-zinc-500">
-                  <LinkCustom href="/login">Login</LinkCustom>
+                  <LinkCustom 
+                    href="/login"
+                    data-testid="login-link" 
+                  >
+                    Login
+                  </LinkCustom>
                   {' '} to get started playing
                 </p>
 

diff --git a/components/LinkCustom/LinkCustom.tsx b/components/LinkCustom/LinkCustom.tsx
@@ -16,13 +16,13 @@ interface ILinkCustomProps {
  * @param props.href - this is the URL you want the link to point to
  * @returns The custom link component
  */
-const LinkCustom = ({ children, href }: ILinkCustomProps): JSX.Element => {
+const LinkCustom = ({ children, href, ... props }: ILinkCustomProps): JSX.Element => {
   return (
     <Link
       className={'font-bold text-orange-600 hover:text-orange-600 hover:underline'}
-      data-testid="linkCustom"
       href={href}
       passHref
+      { ...props }
     >
       {children}
     </Link>