fix(#273): hyphenate data-testid and custom classes

LetsGetTechnical · Jul 18, 2024 · 2a84095 · 2a84095
1 parent 29fa949
commit 2a84095
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/components/Label/Label.test.tsx b/components/Label/Label.test.tsx
@@ -18,12 +18,12 @@ describe('Label', () => {
   variants.forEach((variant) => {
     it(`renders correctly with variant ${variant}`, () => {
       render(
-        <Label data-testid="testLabel" variant={variant}>
+        <Label data-testid="test-label" variant={variant}>
           Test Label
         </Label>
       );
 
-      const label = screen.getByTestId('testLabel');
+      const label = screen.getByTestId('test-label');
       expect(label).toBeInTheDocument();
       if (variant) {
         expect(label).toHaveClass(variantClasses[variant]);
@@ -34,17 +34,17 @@ describe('Label', () => {
   it(`applies additional custom classes correctly`, () => {
     render(
       <Label
-        data-testid="customClassLabel"
-        className="customClassLabel extra-custom-class"
+        data-testid="custom-class-label"
+        className="custom-class-label extra-custom-class"
       >
         Custom Test Label
       </Label>
     );
 
-    const labelCustom = screen.getByTestId('customClassLabel');
+    const labelCustom = screen.getByTestId('custom-class-label');
     expect(labelCustom).toBeInTheDocument();
     if (labelCustom.hasAttribute('className')) {
-        expect(labelCustom).toHaveClass('customClassLabel extra-custom-class');
+        expect(labelCustom).toHaveClass('custom-class-label extra-custom-class');
     }
   });
 });
diff --git a/components/LinkCustom/LinkCustom.test.tsx b/components/LinkCustom/LinkCustom.test.tsx
@@ -5,9 +5,9 @@ import LinkCustom from './LinkCustom';
 describe('LinkCustom Component', () => {
   it('renders with default props', () => {
     render(
-      <LinkCustom children="Test link" data-testid="testLink" href="https://example.com"></LinkCustom>,
+      <LinkCustom children="Test link" data-testid="test-link" href="https://example.com"></LinkCustom>,
     );
-    const link = screen.getByTestId('testLink');
+    const link = screen.getByTestId('test-link');
     expect(link).toBeInTheDocument();
     expect(link).toHaveTextContent('Test link');
     expect(link).toHaveAttribute('href', 'https://example.com');