Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=vertx deploy vertical target instances to match the CPU cores. #361

Merged
merged 1 commit into from
Jun 27, 2023
Merged

=vertx deploy vertical target instances to match the CPU cores. #361

merged 1 commit into from
Jun 27, 2023

Conversation

He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Jun 27, 2023

Summary of changes
Changes introduced in this pull request:

Set the target instances of vertical to match the CPU cores.

@He-Pin
Copy link
Contributor Author

He-Pin commented Jun 27, 2023

@gcnyin Ping , would you like to take a look?

@He-Pin
Copy link
Contributor Author

He-Pin commented Jun 27, 2023

/**

  • The default initial settings max concurrent stream for an HTTP/2 server = 100
    */
    public static final long DEFAULT_INITIAL_SETTINGS_MAX_CONCURRENT_STREAMS = 100;

Which can be ignore for now.

@He-Pin He-Pin force-pushed the vertx_multi_instances branch from a28ae19 to 5b9d894 Compare June 27, 2023 03:37
@gcnyin
Copy link
Contributor

gcnyin commented Jun 27, 2023

@gcnyin Ping , would you like to take a look?

lgtm

@He-Pin He-Pin force-pushed the vertx_multi_instances branch from 5b9d894 to efa90cf Compare June 27, 2023 07:14
@He-Pin
Copy link
Contributor Author

He-Pin commented Jun 27, 2023

@gcnyin @LesnyRumcajs I have updated the pr and address issues.

@He-Pin He-Pin requested a review from LesnyRumcajs June 27, 2023 07:16
LesnyRumcajs
LesnyRumcajs approved these changes Jun 27, 2023
View reviewed changes
Copy link
Owner

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LesnyRumcajs LesnyRumcajs merged commit 0da5bb4 into LesnyRumcajs:master Jun 27, 2023
@LesnyRumcajs LesnyRumcajs mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@He-Pin @gcnyin @LesnyRumcajs