Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support value props #2

Merged
merged 2 commits into from
Jan 15, 2019
Merged

feat: support value props #2

merged 2 commits into from
Jan 15, 2019

Conversation

luyilin
Copy link
Contributor

@luyilin luyilin commented Jan 12, 2019

I find you using inner state to manage the value of input and value props does not work. But value props can still work when use state to manage value. And there are many cases need to use value props like reset a value, etc. So I add the value props.
It's a nice component, I'd like to write a similar component for vue. 😄

Copy link
Owner

@LeoEatle LeoEatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your support. But I'd like to make it better.

src/inputfield.js Show resolved Hide resolved
src/inputfield.js Outdated Show resolved Hide resolved
src/inputfield.js Show resolved Hide resolved
@LeoEatle LeoEatle merged commit 0db850d into LeoEatle:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants