New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(syntax): "name" in "entity.name.type" #92

Merged

Lencerf merged 1 commit into Lencerf:master from Akuukis:entity-name-type

Jan 11, 2024

Contributor

Akuukis commented Jan 10, 2024 •

edited

Loading

Let's fix the scope name, because

none of most popular dark themes has a theme selector for entity.type.*, but rather every theme has a selector for a entity.name.type.*.
the two guides linked in vscode scoping docs (1, 2) suggest to use entity.name.type

before (dark modern theme)	after (dark modern theme)


          fix(syntax): missed "name" in "entity.name.type"

ffca57e

Akuukis changed the title ~~fix(syntax): missed "name" in "entity.name.type"~~ fix(syntax): "name" in "entity.name.type"

Akuukis mentioned this pull request

feat(syntax): support the new oneliner version #95

Merged

Lencerf merged commit 6261bff into Lencerf:master

Akuukis deleted the entity-name-type branch

January 11, 2024 07:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet