Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative path to python (to allow wrapper scripts) #27

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Support relative path to python (to allow wrapper scripts) #27

merged 1 commit into from
Sep 14, 2019

Conversation

vizanto
Copy link
Contributor

@vizanto vizanto commented Sep 9, 2019

This PR allows configuring a workspace relative path to python.

I don't have Beancount installed globally, but use https://direnv.net together with https://nixos.org/nixpkgs/ to handle project dependencies.

Beancount + Fava are packaged with a nix-generated python wrapper script, that includes all the PYTHONPATH variables etc. so that python can find all library dependencies.

I tried to make vscode-beancount run this script and discovered it does not spawn from workspace. This PR fixes that.

@Lencerf Lencerf merged commit 77ee6c2 into Lencerf:master Sep 14, 2019
@bruce3x
Copy link

bruce3x commented Feb 14, 2022

Hi Lencerf, why has this feature been removed? @Lencerf 17289c1

I think it's useful

@vizanto
Copy link
Contributor Author

vizanto commented Mar 9, 2022

☹️

@Lencerf
Copy link
Owner

Lencerf commented Mar 10, 2022

Hello, my impression is that at some point the spawn function changed its signature and the parameter options was gone so I deleted it. Or maybe my memory is wrong and I just completely did not know what I was doing.

Anyway I have added it back in 85bda05. Can you please help test if it works? https://github.com/Lencerf/vscode-beancount/releases/tag/v0.8.1-pre Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants