Markdown link rule-dess #4356
Merged
Markdown link rule-dess #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
commented
Jan 5, 2024
| @@ -247,13 +247,23 @@ pub struct GetSiteMetadataResponse { | |||
| #[cfg_attr(feature = "full", ts(export))] | |||
| /// Site metadata, from its opengraph tags. | |||
| pub struct LinkMetadata { | |||
| #[serde(flatten)] | |||
There was a problem hiding this comment.
This should work okay without any breaking changes.
dessalines
commented
Jan 5, 2024
| .await? | ||
| .into(), | ||
| ); | ||
| return Ok(proxy_image_link(image_url.clone(), context).await?.into()); |
There was a problem hiding this comment.
I commented in the other PR, but this makes it seem like we need to get rid of one of these two pictrs settings bools, since they do the same thing.
Nutomic
approved these changes
Jan 8, 2024
dessalines
added a commit
that referenced
this pull request
Jan 25, 2024
* Add markdown rule to add rel=nofollow for all links * Add markdown image rule to add local image proxy (fixes #1036) * comments * rewrite markdown image links working * add comment * perform markdown image processing in api/apub receivers * clippy * add db table to validate proxied links * rewrite link fields for avatar, banner etc * sql fmt * proxy links received over federation * add config option * undo post.url rewriting, move http route definition * add tests * proxy images through pictrs * testing * cleanup request.rs file * more cleanup (fixes #2611) * include url content type when sending post over apub (fixes #2611) * store post url content type in db * should be media_type * get rid of cache_remote_thumbnails setting, instead automatically take thumbnail from federation data if available. * fix tests * add setting disable_external_link_previews * federate post url as image depending on mime type * change setting again * machete * invert * support custom emoji * clippy * update defaults * add image proxy test, fix test * fix test * clippy * revert accidental changes * address review * clippy * Markdown link rule-dess (#4356) * Extracting opengraph_data to its own type. * A few additions for markdown-link-rule. --------- Co-authored-by: Nutomic <[email protected]> * fix setting * use enum for image proxy setting * fix test configs * add config backwards compat * clippy * machete --------- Co-authored-by: Dessalines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few additions:
OpenGraphDatastruct, so it doesn't have to returnNonefor the thumbnail and content-type.proxy_image_link