-
-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve federated objects from other instances via redirect (fixes #3129) #4073
Conversation
Okay this is good to merge, I cant think of any concrete way this could be used for an attack, and its a major usability improvement. Also added an api test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I resolved the correct version of your crate, if it passes then I spose we're good.
59b724e
to
5972343
Compare
Here's some articles about potential issues with open/user-editable redirects : http://projects.webappsec.org/w/page/13246981/URL%20Redirector%20Abuse https://developers.google.com/search/blog/2009/01/open-redirect-urls-is-your-site-being tl;dr: it can make phishing easier because people think they are still on a trusted site but in reality were redirected to a phishing / scam site |
This case is a bit different because the redirects are only served for fetching Activitypub objects with
Not sure what this is about or how it relates to the PR. |
Sorry, I commented on the wrong PR :/ |
Works in testing. Depends on LemmyNet/activitypub-federation-rust#76 but that could possibly introduce security risks.