Format config/defaults.hjson before committing #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Oct 22, 2021
Comment on lines
+7
to
+13
| # replace // comments with # | ||
| sed -i "s/\/\//#/" "$dest" | ||
| # remove trailing commas | ||
| sed -i "s/,\$//" "$dest" | ||
| # remove quotes around json keys | ||
| sed -i "s/\"//" "$dest" | ||
| sed -i "s/\"//" "$dest" |
There was a problem hiding this comment.
Side note, but its worth asking for hjson support in doku, so we don't have to do this step at all. Open up an issue asking them.
There was a problem hiding this comment.
That would be the three issues linked here by the maintainer. Ive subscribed to them to get notified when they get implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved this logic from LemmyNet/lemmy-docs#102 to this repo, as people might look at config/defaults.hjson directly.