Add blocks screen #1545
Add blocks screen #1545
Conversation
|
I ran the app and blocked one community and one user. Then I navigated to the BlocksActivity, but I couldn't see the user and the community I blocked, I had to drag the screen to trigger the reload, only then the screen showed the user and the community I blocked. I think you can run the update event when the user opens the BlocksActivity to avoid the need to drag the screen to update. Other solution is to update the blocked users/community/instance lists when a block occurs. I think I used the first solution when I worked on this. |
|
Btw thank you very much for continuing the blocks screen work! :) |
|
I didn't want to do that initially because it would make it load first each time they open the screen. But I guess this a common usecase Edit: I have made it so that you can see the current state and in the meantime it loads a newer state. So that you don't see a empty loading screen. |
There was a problem hiding this comment.
I tested and this works great.
Lots of thanks to @rodrigo-fm for laying this foundation!
| @@ -442,7 +442,7 @@ fun PostOptionsDropdown( | |||
| ), | |||
| ) | |||
| withContext(Dispatchers.Main) { | |||
| showBlockCommunityToast(resp, instance, ctx) | |||
| showBlockInstanceToast(resp, instance, ctx) | |||
| onClick = null, | ||
| ) | ||
|
|
||
| IconButton( |
There was a problem hiding this comment.
I like this one a lot, there might be other places we can use this style.
Thanks @rodrigo-fm , I have largely based this PR from yours.
XveWT9Tlws.mp4