Refactor deprecated M1 SwipeToDismiss, use M3 SwipeToDismissBox #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Jun 1, 2024
| @@ -132,12 +132,6 @@ dependencies { | |||
| implementation("io.noties.markwon:image-coil:4.6.2") | |||
| implementation("io.noties.markwon:linkify:4.6.2") | |||
|
|
|||
| // Accompanist | |||
| implementation("com.google.accompanist:accompanist-pager:0.34.0") | |||
| @@ -184,7 +178,7 @@ dependencies { | |||
| implementation("androidx.compose.material:material-icons-extended") | |||
|
|
|||
| implementation("org.ocpsoft.prettytime:prettytime:5.0.8.Final") | |||
| implementation("androidx.navigation:navigation-compose") | |||
| implementation("androidx.navigation:navigation-compose:2.7.7") | |||
There was a problem hiding this comment.
This version should come automatically with bom, no?
There was a problem hiding this comment.
It did not for me, must ve come from accompanist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use M3 replacement.
Whats strange is that they named it "Swipe left" but dragging to right is swiping right? So I have corrected the naming to fit the behaviour.
This was the last accompanist dependency. Also the last M1 component.
Fixes #1479
studio64_JJnhZAKFzZ.mp4