Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update kotlin monorepo to v2 (major) #1523

Merged
merged 1 commit into from
May 22, 2024

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented May 22, 2024

The 2.0.0 kotlin compiler has been released already. It just moved now to a plugin

https://developer.android.com/jetpack/androidx/releases/compose-kotlin

@MV-GH MV-GH requested a review from dessalines as a code owner May 22, 2024 16:41
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thx. How do you learn about these gradle changes for compose btw?

@dessalines dessalines enabled auto-merge (squash) May 22, 2024 16:46
@dessalines dessalines merged commit 52b7529 into LemmyNet:main May 22, 2024
1 check passed
@MV-GH MV-GH deleted the bump/kotlin branch May 22, 2024 16:53
@MV-GH
Copy link
Collaborator Author

MV-GH commented May 22, 2024

Mostly from the noise in the kotlin compose slack channel

Also beware that kotlin compiler 2 brings some changes to recompositions. Strong skipping is now enabled by default. This is good but might cause some issues if we have something wrongly configured. So I would at least wait a bit to do a release.

https://medium.com/androiddevelopers/jetpack-compose-strong-skipping-mode-explained-cbdb2aa4b900

Important changes

  • Composables with unstable parameters can be skipped.
  • Unstable parameters are compared for equality via instance equality (===)
  • Stable parameters continue to be compared for equality with Object.equals()
  • All lambdas in composable functions are automatically remembered. This means you will no longer have to wrap lambdas in remember to ensure a composable that uses a lambda, skips.

That last one is very good, many of my recompositions changes were that, (my PR is getting pretty far but will have to change now)

@dessalines
Copy link
Member

Sweet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants