Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set specific versions for runtime-livedata. #1502

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

dessalines
Copy link
Member

No description provided.

@dessalines dessalines requested a review from MV-GH as a code owner May 15, 2024 23:50
@dessalines dessalines enabled auto-merge (squash) May 15, 2024 23:51
@dessalines dessalines merged commit 8626315 into main May 15, 2024
2 checks passed
@MV-GH
Copy link
Collaborator

MV-GH commented May 26, 2024

@dessalines
Copy link
Member Author

Whoops. android studio complained about these. I'll revert this then.

dessalines added a commit that referenced this pull request May 27, 2024
dessalines added a commit that referenced this pull request May 27, 2024
@MV-GH
Copy link
Collaborator

MV-GH commented May 29, 2024

Actually even with that change I am still experiencing it in different parts of the app. Opening the imageviewer will result in crash

java.lang.IllegalStateException: CompositionLocal LocalLifecycleOwner not present

We can't release until we fix this.

Edit found out why
https://issuetracker.google.com/issues/336842920

Lifecycle 2.8 requires compose 1.7 But compose 1.7 is still in alpha so there is no Compose BOM release yet

So we either wait for that or
we use this as interim
https://github.com/chrisbanes/compose-bom

@dessalines
Copy link
Member Author

Seems like using https://github.com/chrisbanes/compose-bom is the best short-term fix, so we don't have to make any code changes.

dessalines added a commit that referenced this pull request May 31, 2024
dessalines added a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants