Community: Add Share drop down in community view. #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV-GH
approved these changes
Oct 7, 2023
dessalines
reviewed
Oct 9, 2023
app/src/main/java/com/jerboa/ui/components/community/CommunityActivity.kt
Outdated
Show resolved
Hide resolved
lubosz
force-pushed
the
share-community
branch
from
4411000
to
8c8d80d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that there is no button to share a community url. This patch fixes that.
Not sure if this is the best way to create a community URL, let me know if I am missing something.
Also not sure if https can be expected from all instances. Didn't find any places were instance / community URLs are already created.