Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move save to the topbar of user settings and deduplicate topbar code #1243

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Move save to the topbar of user settings and deduplicate topbar code #1243

merged 5 commits into from
Sep 20, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Sep 17, 2023

  • Moved save button to topbar for usersettings
  • Add reuseable action topbar
  • Remove unused translations (Its a Android Studio tool)
KHUj0QASQ8.mp4

dessalines
dessalines reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I'd just change save -> submit then we can merge.

app/src/main/java/com/jerboa/ui/components/comment/edit/CommentEdit.kt Show resolved Hide resolved
app/src/main/java/com/jerboa/ui/components/common/AppBars.kt Outdated Show resolved Hide resolved
dessalines
dessalines approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

app/src/main/java/com/jerboa/ui/components/common/AppBars.kt
onSubmitClick: () -> Unit,
fun ActionTopBar(
onBackClick: () -> Unit,
onActionClick: () -> Unit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thx

@dessalines dessalines merged commit a463c69 into LemmyNet:main Sep 20, 2023
1 check passed
@MV-GH MV-GH deleted the refactor/move_save_to_topbar branch September 20, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MV-GH @dessalines