Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private tabs for FireFox #1216

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Conversation

Copy link
Collaborator

@MV-GH MV-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this in the else section of the useCustomTab

        if (usePrivateTab) {
            intent.putExtra("com.google.android.apps.chrome.EXTRA_OPEN_NEW_INCOGNITO_TAB", true)
            intent.putExtra("private_browsing_mode", true)
        }

It is supposed to work too if you don't use a customtab

@dankeast
Copy link
Contributor Author

dankeast commented Sep 4, 2023

Add this in the else section of the useCustomTab

        if (usePrivateTab) {
            intent.putExtra("com.google.android.apps.chrome.EXTRA_OPEN_NEW_INCOGNITO_TAB", true)
            intent.putExtra("private_browsing_mode", true)
        }

It is supposed to work too if you don't use a customtab

The option in the menu is "Use private custom tabs if available" so I just followed the current pattern for Chrome. This makes a lot of sense though, so I've changed this to always send the extras if the option is set, and update the option in the menu

@MV-GH MV-GH enabled auto-merge (squash) September 4, 2023 16:35
@MV-GH MV-GH merged commit 86674b9 into LemmyNet:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants