Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Global instances of gamepad #7

Merged
merged 12 commits into from
Aug 21, 2024
Merged

Conversation

ion098
Copy link
Collaborator

@ion098 ion098 commented May 29, 2024

Right now users can make multiple instances of a controller, but they'll run into issues with text printing. This PR fixes that by creating global instances of the master and partner controllers and hiding the constructors for the controller.

Download the template for this pull request:

Note

This is auto generated from Add Template to Pull Request

curl -o [email protected]+8f2606.zip https://nightly.link/LemLib/Gamepad/actions/artifacts/1807754856.zip;
pros c fetch [email protected]+8f2606.zip;
pros c apply [email protected]+8f2606;
rm [email protected]+8f2606.zip;

@ion098 ion098 marked this pull request as ready for review May 29, 2024 17:17
@ion098 ion098 requested a review from Aang099 May 29, 2024 17:17
@ion098 ion098 requested a review from SizzinSeal August 13, 2024 17:37
src/gamepad/controller.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
include/gamepad/controller.hpp Outdated Show resolved Hide resolved
include/gamepad/controller.hpp Outdated Show resolved Hide resolved
@ion098 ion098 force-pushed the feature/global-instances branch from bfe697f to 1b5c5f8 Compare August 19, 2024 21:00
@ion098 ion098 requested a review from SizzinSeal August 19, 2024 21:01
src/gamepad/controller.cpp Show resolved Hide resolved
src/gamepad/controller.cpp Show resolved Hide resolved
@ion098 ion098 changed the title Make global instances of gamepad ✨ Global instances of gamepad Aug 21, 2024
Copy link
Member

@SizzinSeal SizzinSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SizzinSeal SizzinSeal merged commit 9c1e994 into main Aug 21, 2024
3 checks passed
@SizzinSeal SizzinSeal deleted the feature/global-instances branch August 21, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants