Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add pagination to collaborators collector #275

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: Add pagination to collaborators collector #275

merged 3 commits into from
Dec 11, 2023

Conversation

JakubBiel
Copy link
Contributor

What's being changed?

  1. Added pagination to repository collaborators collector. Without it, it only returns 30 collaborators as it's a default per page.
  2. Fixed typo in deletion protection rule check for repository rulesets. See documentation.

Is this PR related to an existing issue?

Check off the following:

  • This PR follows the CONTRIBUTION.md guidelines
  • I have self-reviewed my changes before submitting the PR

@JakubBiel JakubBiel requested a review from a team as a code owner December 10, 2023 21:00
@ghost
Copy link

ghost commented Dec 10, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@noamd-legit noamd-legit merged commit 861ecbb into Legit-Labs:main Dec 11, 2023
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamd-legit noamd-legit noamd-legit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakubBiel @noamd-legit