Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add new input to handle overlay click #1488

Merged

Conversation

elenagarrone
Copy link
Contributor

@elenagarrone elenagarrone commented Dec 5, 2024

workerB

Description

Add a new input to the modal called closeOnOverlayClick to set wether the modal should close on click of the overlay or not. The new input is set to true by default so that it doesn't cause any breaking change.

Input set to true:

Screen.Recording.2024-12-10.at.15.52.07.mov

Input set to false:

Screen.Recording.2024-12-10.at.15.53.24.mov

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage
  • I have added the functionality to the test app
  • I have provided a story in storybook to document the changes
  • I have added the documentation
  • I have added any new public feature modules to public-api.ts

@elenagarrone elenagarrone requested a review from a team as a code owner December 5, 2024 11:17
@github-actions github-actions bot added the deployed The branch is deployed to GitHub Pages label Dec 5, 2024
@elenagarrone elenagarrone force-pushed the can-145-modal-overlay branch 2 times, most recently from 59ed032 to 140d2a3 Compare December 10, 2024 16:09
@elenagarrone elenagarrone enabled auto-merge (rebase) December 10, 2024 16:40
@elenagarrone elenagarrone merged commit 2d608bf into Legal-and-General:master Dec 11, 2024
3 checks passed
Copy link
Contributor

🎉 This PR is included in version 12.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed The branch is deployed to GitHub Pages released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants