Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio-button): update position of toggle to account for longer labels #1293

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

taraculpin
Copy link
Contributor

Description

Fixes #827

Sets the position of the radio button to absolute and adds fixed padding to prevent the radio button stretching when the label text goes over multiple lines

Issue Fix
image image

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage
  • I have added the functionality to the test app
  • I have provided a story in storybook to document the changes
  • I have added the documentation
  • I have added any new public feature modules to public-api.ts

@taraculpin taraculpin requested a review from a team as a code owner October 25, 2023 14:45
@elenagarrone
Copy link
Contributor

@taraculpin thanks for this! I will deploy it once the workflow starts to run so I can have a quick look there 👍

In the meantime would you mind changing the commit message to:

fix(radio-button): update position of toggle to account for longer labels

or similar please? The important bit is the fix(radio-button) so that the release notes are created correctly ☺️

@github-actions github-actions bot added the deployed The branch is deployed to GitHub Pages label Oct 25, 2023
@elenagarrone
Copy link
Contributor

Tested on deployed environment and it's fixed 👍 Thanks @taraculpin 👏

Left is branch environment and right is main environment.
image

@taraculpin taraculpin changed the title fix: fix radio button position to account for longer labels fix(radio-button): update position of toggle to account for longer labels Oct 25, 2023
@elenagarrone elenagarrone merged commit 8db0db6 into Legal-and-General:master Oct 26, 2023
3 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed The branch is deployed to GitHub Pages released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bullet point turns to oval on smaller screen sizes when the label text is longer
4 participants