Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DSM Integration package #238

Closed
owensgit opened this issue Mar 3, 2021 · 1 comment · Fixed by #258
Closed

Remove DSM Integration package #238

owensgit opened this issue Mar 3, 2021 · 1 comment · Fixed by #258
Assignees
@andy-polhill
Labels
released

Comments

@owensgit
Copy link
Contributor

owensgit commented Mar 3, 2021 •
edited by andy-polhill
Loading

The DSM integration package is causing a few headaches:

  1. Potential blocker for Storybook v6 upgrade
  2. Not well maintained by DSM

It's been agreed between the package should be removed and an alternative method of displaying Angular components in the DSM should be adopted.
@owensgit owensgit mentioned this issue Mar 4, 2021
Closed
@andy-polhill andy-polhill self-assigned this Mar 12, 2021
andy-polhill added a commit to andy-polhill/canopy that referenced this issue Mar 12, 2021
@andy-polhill
refactor(dsm): removes invision dsm
a40075b 
We have decided to remove Invision DSM and opt for a more manual process of linking examples. The
DSM package had a very large dependency tree which was prone to vulnerabilities, these were rarely
fixed within an appropriate timeframe. It also forced us into specific versions of dependences and
at times held us back from upgrading Storybook.

fix Legal-and-General#238
andy-polhill added a commit to andy-polhill/canopy that referenced this issue Mar 12, 2021
@andy-polhill
refactor(dsm): removes invision dsm
ea7de14 
We have decided to remove Invision DSM and opt for a more manual process of linking examples. The
DSM package had a very large dependency tree which was prone to vulnerabilities, these were rarely
fixed within an appropriate timeframe. It also forced us into specific versions of dependences and
at times held us back from upgrading Storybook.

fix Legal-and-General#238
@andy-polhill andy-polhill mentioned this issue Mar 12, 2021
Merged
7 tasks
andy-polhill added a commit that referenced this issue Mar 15, 2021
@andy-polhill
refactor(dsm): removes invision dsm
e5b5a53 
We have decided to remove Invision DSM and opt for a more manual process of linking examples. The
DSM package had a very large dependency tree which was prone to vulnerabilities, these were rarely
fixed within an appropriate timeframe. It also forced us into specific versions of dependences and
at times held us back from upgrading Storybook.

fix #238
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 5.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-polhill andy-polhill

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(dsm): removes invision dsm andy-polhill/canopy
3 participants
@owensgit @andy-polhill @elenagarrone