Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #22 #25

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Refactor #22 #25

merged 3 commits into from
Jul 13, 2024

Conversation

KoungQ
Copy link
Member

@KoungQ KoungQ commented Jul 13, 2024

이슈에서 내용 확인부탁드립니다.

@KoungQ KoungQ added the Refactor 코드 리펙토링 label Jul 13, 2024
@KoungQ KoungQ self-assigned this Jul 13, 2024
Copy link
Member

@hyxklee hyxklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직상 문제는 없어 보입니다! 구현 고생하셨습니다! 차후에 에러 메시지 정도만 enum으로 관리하면 좋을 것 같습니다!

@KoungQ KoungQ merged commit 38886fa into main Jul 13, 2024
2 checks passed
@KoungQ KoungQ deleted the Refactor-#22 branch July 16, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 코드 리펙토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants