New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseDescription using regex #752

Open

csalg wants to merge 5 commits into LeetCode-OpenSource:master from csalg:parseDescription-using-regex

csalg commented Oct 26, 2021

There are several issues open regarding parseDescription breaking the whole extension, e.g. #749, #715

The problem seems to be that vscode-leetcode-cli sometimes prepends a few lines on top of the output, which breaks the parseDescription method.

This PR addresses this issue in two ways:

It uses regex to parse the output instead of breaking the output into lines and hardcoding in which line each property should be. This solves tthe issue of the output having lines prepended.
It assumes that the string can be empty or formatting might change and will not break under those circumstances, instead providing some defaults.

csalg added 5 commits

October 26, 2021 08:52


          Update parseDescription

8f85142


          Fix formatting

811f849


          Move comments so they are on their own line

55e5517


          Fix prettier again

1d141cf


          Remove newlines

39d73d1

Author

csalg commented Oct 26, 2021

Additionally, I wrote two regression tests but I am not sure what to do with them. Is there a different repo with tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet