Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get slug from problem list for a new option of filename in English. #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −2
Open

Get slug from problem list for a new option of filename in English. #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/commands/list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ export async function listProblems(): Promise<IProblem[]> {
const result: string = await leetCodeExecutor.listProblems(showLocked, useEndpointTranslation);
const problems: IProblem[] = [];
const lines: string[] = result.split("\n");
const reg: RegExp = /^(.)\s(.{1,2})\s(.)\s\[\s*(\d*)\s*\]\s*(.*)\s*(Easy|Medium|Hard)\s*\((\s*\d+\.\d+ %)\)/;
const reg: RegExp = /^(.)\s(.{1,2})\s(.)\s\[\s*(\d*)\s*\]\s*(.*)\s*(Easy|Medium|Hard)\s*\((\s*\d+\.\d+ %)\)\s*(.*)/;
const { companies, tags } = await leetCodeExecutor.getCompaniesAndTags();
for (const line of lines) {
const match: RegExpMatchArray | null = line.match(reg);
if (match && match.length === 8) {
if (match && match.length === 9) {
const id: string = match[4].trim();
problems.push({
id,
Expand All @@ -33,6 +33,7 @@ export async function listProblems(): Promise<IProblem[]> {
name: match[5].trim(),
difficulty: match[6].trim(),
passRate: match[7].trim(),
slug: match[8].trim(),
companies: companies[id] || ["Unknown"],
tags: tags[id] || ["Unknown"],
});
Expand Down
2 changes: 2 additions & 0 deletions src/commands/show.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ async function resolveRelativePath(relativePath: string, node: IProblem, selecte
return node.id;
case "name":
return node.name;
case "slug":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to think for a better name of this new placeholder, slug is not straightforward to me at least...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got me...
I don't know what slug means in problem list.
Maybe name_en？

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this What is a “slug” in Django:it is created from the title by down-casing all letters, and replacing spaces by hyphens-.
It's not easy to find a word to replace "slug", "short-label"?"kebab-case-title"? or just "slug"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I like the idea to provide English name as the file name. But there is one problem: people might ask 'Ok, we have the slug styled name, so what about the camel case/pascal case/snake case'?

I think (maybe) a better solution here is having a setting to specify whether to use translated name as the file name, and then, we can provide different style option to the user(kebab, snake, pascal, ...)?

return node.slug;
case "camelcasename":
return _.camelCase(node.name);
case "pascalcasename":
Expand Down
3 changes: 3 additions & 0 deletions src/explorer/LeetCodeNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ export class LeetCodeNode {
public get name(): string {
return this.data.name;
}
public get slug(): string {
return this.data.slug;
}

public get state(): ProblemState {
return this.data.state;
Expand Down
2 changes: 2 additions & 0 deletions src/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export interface IProblem {
state: ProblemState;
id: string;
name: string;
slug: string;
difficulty: string;
passRate: string;
companies: string[];
Expand All @@ -88,6 +89,7 @@ export const defaultProblem: IProblem = {
state: ProblemState.Unknown,
id: "",
name: "",
slug: "",
difficulty: "",
passRate: "",
companies: [] as string[],
Expand Down