Fix training data being generated without its flag #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooskagh
approved these changes
Aug 19, 2018
dubslow
commented
Aug 19, 2018
| GameResult::UNDECIDED, tree_[idx]->GetPositionHistory())); | ||
| if (training) { | ||
| // Append training data. The GameResult is later overwritten. | ||
| training_data_.push_back(tree_[idx]->GetCurrentHead()->GetV3TrainingData( |
There was a problem hiding this comment.
Shouldn't this be emplace_back?
There was a problem hiding this comment.
It's one copy with push_back() and probably one copy with emplace_back() too (surely not less).
I don't really have a preference here actually.
There was a problem hiding this comment.
Oh right, forgot that the argument to push_back isn't actually a constructor call lol
borg323
pushed a commit
to borg323/lc0
that referenced
this pull request
Sep 6, 2018
* Fix training data being generated without its flag * Cleaner terminal node output in verbose stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.