add simple JS backend #2072
Draft
add simple JS backend #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borg323
reviewed
Oct 6, 2024
| @@ -45,7 +45,7 @@ struct WeightsToOnnxConverterOptions { | |||
| std::string output_mlh = "/output/mlh"; | |||
| int batch_size = -1; | |||
| int opset = 17; | |||
| bool alt_mish = false; // Use "Mish" approximation (fp32 only). | |||
| bool alt_mish = true; // Use "Mish" approximation (fp32 only). | |||
There was a problem hiding this comment.
This is not the way to do it, add a flag in leela2onnx.cc.
| return PopulateStdNodeFields(node, name, input, "Selu"); | ||
| auto out = PopulateStdNodeFields(node, name + "/elu", input, "Elu"); | ||
| AddFloatAttribute(node, "alpha", 1.0507); | ||
| return Mul(name, out, FloatOnnxConst({1.67326}, {1})); | ||
| } |
There was a problem hiding this comment.
I would suggest using a flag, but probably doesn't make a difference. Better keep the Selu operator unchanged and add an Elu one, then make the change in the converter (with a comment).
| #else | ||
|
|
||
| bool GetLine(std::string& line) { | ||
| return std::getline(std::cin, line); |
There was a problem hiding this comment.
This breaks the build, I think one solution is to change it to return !!std::getline(std::cin, line);.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was told this might be desirable. A couple things to note:
If anyone has any thoughts on whether this is warranted, I’d love to know! (Do let me know what you think!)
Some more technical details: This works by converting an Lc0 network to ONNX format (with
leela2onnx) and then using the ORT‐web APIs to allow Lc0 to interface with the network through JavaScript.