-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change mlh threshold effect to create a smooth transition #1844
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fb3b031
changed threshold effect to create a smooth transition
Naphthalin d51267b
Merge branch 'master' into soft-mlh
Naphthalin ccf212f
Merge branch 'master' into soft-mlh
Naphthalin 2832267
Merge branch 'master' into soft-mlh
Naphthalin 4a24371
Merge branch 'master' into soft-mlh
Naphthalin cc07b4e
renamed GetM() to GetMUtility() to differentiate it from GetM()
Naphthalin 2debd43
added comment
Naphthalin 79f0a06
changed duplicate GetMUtility() function into wrapper
Naphthalin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment what
GetM
function does?I though it returns moves left, but then it returns 0 if |q| < q_thredshol, so it's not clear what it's supposed to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It returns the "moves left head effect" term which gets added to the PUCT score, so that
PUCT = Q + U + M
. This PR doesn't change the meaning ofGetM()
, but your comment makes clear that it was already confusing before this PR, so a comment (even if it has nothing to do with this PR) would certainly justified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this before the function declaration.
Could you add this in this PR?
Also,
GetM()
sounds like a wrong name for this function. Maybe rename toGetQAdjustment()
?(it's more or less clear that it's based on M because it inside the MEvaluator class).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Settled at
GetMUtility()
because it best describes both where it comes from (M) and what it is (a utility).