only use thread binding with blas backend #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to call (the Numa::Init function can also keep the static flag to make sure it's not initialized twice) |
mooskagh
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently binding threads to a windows processor group is a bad idea if lc0 is used simultaneously with SF for analysis: both engines try to use the same cores.
Since thread binding is only useful for more than 32 threads, in most cases it may be better to let windows handle the allocation.
The only real use case is with the blas backend, so here thread binding is made conditional on
USE_BLAS. This does not include the eigen backend, but I think this is acceptable as it is mainly intended as a reference implementation.